Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Governor Select #141

Closed
Shuzhengz opened this issue Jan 21, 2022 · 14 comments
Closed

Manual Governor Select #141

Shuzhengz opened this issue Jan 21, 2022 · 14 comments
Labels
enhancement New ideas or features to add help wanted Extra attention is needed
Milestone

Comments

@Shuzhengz
Copy link
Collaborator

Shuzhengz commented Jan 21, 2022

Let the user select the power plan (and possibly modify) manually (to any avaliable governor)

@Shuzhengz Shuzhengz added the enhancement New ideas or features to add label Jan 21, 2022
@JakeRoggenbuck
Copy link
Owner

Yee, we have a acs set gov performance but I don't know if it will stay like that if it's running on acs run

@JakeRoggenbuck
Copy link
Owner

yea, to better state that, doing acs run will change the user set default. If acs run is not on, then I think the user can just set it.

@JakeRoggenbuck JakeRoggenbuck added the help wanted Extra attention is needed label Jan 21, 2022
@JakeRoggenbuck JakeRoggenbuck added this to the 0.1.9 milestone Jan 30, 2022
@JakeRoggenbuck
Copy link
Owner

I'll try to work on this

@Shuzhengz
Copy link
Collaborator Author

o i actually already started on this lol

@JakeRoggenbuck
Copy link
Owner

Oh, yee! Yea, you can go for it!

@Shuzhengz
Copy link
Collaborator Author

@JakeRoggenbuck okay so i could't figure out how to make apply_to_cpus() work on custom governors without making things unsafe, so yeah kinda stuck lol
I did get schedutil working with #290 tho

@JakeRoggenbuck
Copy link
Owner

@JakeRoggenbuck okay so i could't figure out how to make apply_to_cpus() work on custom governors without making things unsafe, so yeah kinda stuck lol I did get schedutil working with #290 tho

Awesome, sounds good!

@JakeRoggenbuck
Copy link
Owner

We could make like a "are you very sure you wanna do this? [y/N]" thingy

@Shuzhengz
Copy link
Collaborator Author

yea lol

@Shuzhengz
Copy link
Collaborator Author

press y for your computer to explode

@JakeRoggenbuck
Copy link
Owner

Was this done in #290?

@JakeRoggenbuck
Copy link
Owner

@Shuzhengz

@Shuzhengz
Copy link
Collaborator Author

Sort of, but since we're not gonna do this we should prob close it

@JakeRoggenbuck
Copy link
Owner

Alright, should we have an issue for "Discuss future use of user inputted gov"? Also, we might want to add some of the other govs and stuff that intel has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New ideas or features to add help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants