Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU governors don't get set back to performance when laptop is above 20% #74

Closed
Camerooooon opened this issue Sep 8, 2021 · 3 comments
Closed

CPU governors don't get set back to performance when laptop is above 20% #74

Camerooooon opened this issue Sep 8, 2021 · 3 comments
Assignees
@Camerooooon
Labels
enhancement New ideas or features to add Needs laptop test We need to test this on a laptop
Milestone
0.1.5

Comments

@Camerooooon
Copy link
Collaborator

This is what I believe the expect behavior to be

If the lid is closed then governors will be set to powersave regardless of charge state
If laptop is plugged in governors will be set to performance
If laptop is bellow 20% governors will be set to powersave unless laptop is charging

Right now it doesn't even bother setting the governors back to performance.
@JakeRoggenbuck
Copy link
Owner

Yea, I agree. We should change it so that it sets it back to performance when it's either plugged in or above a certain value maybe somewhere 50-70%

@JakeRoggenbuck JakeRoggenbuck added the enhancement New ideas or features to add label Sep 8, 2021
@Camerooooon
Copy link
Collaborator Author

I'll work on this :)

@JakeRoggenbuck JakeRoggenbuck added the Needs laptop test We need to test this on a laptop label Sep 8, 2021
@Camerooooon
Copy link
Collaborator Author

This should work now since the battery will only ever charge when plugged in and the laptop is always in performance when plugged in.

@JakeRoggenbuck JakeRoggenbuck added this to the 0.1.5 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Camerooooon Camerooooon

Labels
enhancement New ideas or features to add Needs laptop test We need to test this on a laptop
Projects
None yet
Milestone
0.1.5
Development

No branches or pull requests
2 participants
@JakeRoggenbuck @Camerooooon