Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "engines" from package.json #45

Closed
geta6 opened this issue Jan 31, 2017 · 8 comments
Closed

Remove "engines" from package.json #45

geta6 opened this issue Jan 31, 2017 · 8 comments

Comments

@geta6
Copy link

geta6 commented Jan 31, 2017

This module won't install with yarn that seems to be more strict about checking engines flags than the npm client.

$ node --version
v7.4.0

$ yarn
yarn install v0.19.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error react-fastclick@3.0.0: The engine "node" is incompatible with this module. Expected version "6.9.4".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
@JakeSidSmith
Copy link
Owner

I had no idea this'd be an issue as:

Note that, unless the user has set the engine-strict config flag, this field is advisory only.
engineStrict: This feature was deprecated with npm 3.0.0
Source

I haven't used yarn yet, myself. Does yarn have an equivalent that might fix the issue for you?
This issue says that you can --ignore-engines, would that solve your problem?

@caio-ribeiro-pereira
Copy link

@JakeSidSmith if you remove "engine" will solve better instead fix a node version. Because this is a node's module, the "engine" is useful when you are creating a server and some hosts like Heroku/Openshift use it to setup nodejs according to a fixed version in this property.

@caio-ribeiro-pereira
Copy link

and please let me know when solve this issue, because I really wanna use this lib in my project https://watchcoins.herokuapp.com thanks!

@JakeSidSmith
Copy link
Owner

Heroku / Openshift wouldn't use this libs engine version though, it'd use the one from your project's package.

I may, however just remove this. Kind of pissed that yarn is messing this up. The engines are only supposed to be guidelines for what version a library is proven to work in. :/

@caio-ribeiro-pereira
Copy link

Well, if you need the engine property, change the fixed version to a flexible one, like: >= 6.0.0, or ~6.x.x,

@JakeSidSmith
Copy link
Owner

I don't want people using 5 or less to have issues though. May just set to *. I'll have a think.

@faceyspacey
Copy link

+1

waiting on this as well

@caio-ribeiro-pereira
Copy link

me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants