Q: what is a breaking change

[armano2]

I was wandering what should be considered breaking change:

i'm trying to follow:

• patch: only hotfixes for bugs and issues, or missing fields in nodes.
• minor: can change AST structure but do not change fields in nodes.
• major: changes of types, names, properties and all changes that for sure are going to break code.

it will be nice if we will have official guideline because right now it's ... not really clear.

@JamesHenry @uniqueiniquity what do you think?

[uniqueiniquity]

Can you give an example of a "minor" change under this approach? I would call what you described a major change, but I might be missing something.

[armano2]

• patch: fix: set parent nodes correctly for virtual files #78
• minor: feat: add missing TSAsExpression node #69
• major: BREAKING: add missing TSImportEqualsDeclaration node #71

unless we should have minor only as changes that adds functionality but do not change existing one (semver)

[uniqueiniquity]

Ah. Yep, I would agree that #69 is minor, since I would say that adds functionality but doesn't break existing users.

[armano2]

someone should write contributing guide, and include it there