Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow templates in labels #113

Closed
dblock opened this issue Sep 23, 2021 · 4 comments
Closed

Allow templates in labels #113

dblock opened this issue Sep 23, 2021 · 4 comments

Comments

@dblock
Copy link
Contributor

dblock commented Sep 23, 2021

This didn't work:

labels: untriaged, release, v{{ env.VERSION }}

Screen Shot 2021-09-23 at 8 20 52 AM

@JasonEtco
Copy link
Owner

Ooh I like that, we should definitely allow this. I'd mean a change here:

const templated = {
body: env.renderString(body, templateVariables),
title: env.renderString(attributes.title, templateVariables)
}

Probably something like:

labels: listToArray(attributes.labels).map(label => env.renderString(label, templateVariables)

And then use template.labels in the final issue payload. This seems complicated in conjunction with #100, when issue labels will require removing labels as well as adding them, but we can cross that bridge when we get to it.

@JasonEtco
Copy link
Owner

Looks like there's already a PR for this in progress: #95

@dblock
Copy link
Contributor Author

dblock commented Sep 29, 2021

Finished in #119

@dblock
Copy link
Contributor Author

dblock commented Jan 5, 2022

This is fixed in https://github.com/dblock/create-a-github-issue, a maintained fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants