Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to a JavaScript action #55

Closed
JasonEtco opened this issue Apr 4, 2020 · 0 comments · Fixed by #76
Closed

Convert to a JavaScript action #55

JasonEtco opened this issue Apr 4, 2020 · 0 comments · Fixed by #76
Labels
enhancement New feature or request

Comments

@JasonEtco
Copy link
Owner

I'd like to convert this to being a JavaScript action, so that users of it don't need to build the Docker container in their workflow - it'd be a little faster ⚡️

However, committing node_modules is a non-starter for me - I think that's an anti-pattern that I'm absolutely going to avoid. Tools like @zeit/ncc are a good enough compromise, so I'll be trying that out (also would mean I can write TypeScript actions without any extra work 😍).

I'd like to investigate/setup a GitHub Actions workflow to do the building and publishing to the specific tags, to avoid having a dist folder in the master branch (again, an anti-pattern). @mheap 👋 has done some awesome work on github-action-auto-compile-node, I'm hoping to just pull that in, potentially also with Actions Tagger.

cc this Twitter thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant