Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output to tell whether the issue was created or updated #85

Closed
sargunv opened this issue Feb 22, 2021 · 7 comments
Closed

Output to tell whether the issue was created or updated #85

sargunv opened this issue Feb 22, 2021 · 7 comments

Comments

@sargunv
Copy link

sargunv commented Feb 22, 2021

I'm currently using this in a scheduled workflow to check NPM advisories against our yarn.lock and file issues when an advisory applies to our dependencies. We'd rely on Dependabot, but that has a file size limit of 0.5MB and our monorepo lockfile is well beyond that.

I use the update_existing option to keep updating the existing issues rather than flooding the repo with new ones. However, I'd like to add the ability to send a Slack message when a new issue is created (but not when one is simply updated). Unfortunately, there's no output from this action that tells my GH Actions job whether the issue was actually created or just updated (or neither).

Would it be possible to get such an output?

@dblock
Copy link
Contributor

dblock commented Sep 21, 2021

Anything other than https://github.com/JasonEtco/create-an-issue#outputs still needed for this one?

@sargunv
Copy link
Author

sargunv commented Sep 22, 2021

I no longer need this, but the intention was for an output that tells me whether the issue was created or it was simply updated, not just the id/url of the issue.

@dblock
Copy link
Contributor

dblock commented Sep 28, 2021

I think #112 does it, care to confirm?

@sargunv
Copy link
Author

sargunv commented Sep 28, 2021

Maybe I missed it but I don't see a new output there?

@dblock
Copy link
Contributor

dblock commented Sep 29, 2021

I was confused on what "output" meant. I saw output :)

✔  success   Existing issue [RELEASE] Release version 2.0.0#24: https://github.com/dblock/opensearch-build/issues/24 found but not updated

See #120 for an implementation.

@sargunv
Copy link
Author

sargunv commented Sep 29, 2021

#120 looks great, thank you!

@JasonEtco
Copy link
Owner

I'll close this as @dblock has implemented it in their fork, and it hasn't come up other than this issue. If anyone still wants it, happy to review a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants