Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GPG key file is empty in flatpak repo #77

Closed
noelmiller opened this issue Mar 15, 2024 · 12 comments
Closed

[BUG] GPG key file is empty in flatpak repo #77

noelmiller opened this issue Mar 15, 2024 · 12 comments
Labels
can't duplicate Bugs that can't be consistently duplicated question Further information is requested

Comments

@noelmiller
Copy link
Collaborator

Describe the bug
For some reason, the flatpak.trustedkeys.gpg is an empty file when installing from generated bluefin ISO.

To Reproduce

docker run --rm --privileged --pull always --volume .:/github/workspace/build  ghcr.io/jasonn3/build-container-installer:main VERSION=39 IMAGE_REPO=ghcr.io/ublue-os IMAGE_NAME=bluefin IMAGE_TAG=39-testing VARIANT=Silverblue FLATPAK_REMOTE_REFS_DIR=/github/workspace/build/flatpaks

Expected behavior
File should not be empty

Screenshots
Discussion happening in discord ISO thread: https://discord.com/channels/1072614816579063828/1192504002252914791

@noelmiller noelmiller added bug Something isn't working help wanted Extra attention is needed labels Mar 15, 2024
@noelmiller noelmiller changed the title [BUG] GPG key is empty in flatpak repo [BUG] GPG key file is empty in flatpak repo Mar 15, 2024
@JasonN3
Copy link
Owner

JasonN3 commented Mar 15, 2024

Can't replicate. Steps used:

  1. docker run --rm --privileged --pull always --volume .:/github/workspace/build ghcr.io/jasonn3/build-container-installer:main VERSION=39 IMAGE_REPO=ghcr.io/ublue-os IMAGE_NAME=bluefin IMAGE_TAG=39-testing VARIANT=Silverblue FLATPAK_REMOTE_REFS_DIR=/github/workspace/build/flatpaks
  2. Boot from resulting deploy.iso
  3. Create a user
  4. Run flatpak update
    image
  5. Run flatpak install org.mozilla.firefox
    image

@noelmiller
Copy link
Collaborator Author

noelmiller commented Mar 15, 2024

Really odd. Can you pull down the flatpaks folder from Bluefin PR I'm using and take a look? Maybe there is something goofy going on with how I defined the flatpaks in there. ublue-os/bluefin#1022

@JasonN3
Copy link
Owner

JasonN3 commented Mar 15, 2024

So far the build process looks fine. I haven't installed the OS yet, but did you have internet while the build process was running? It pulls down the flatpakrepo file in order to extract the gpgkey. If it failed to pull it down the file would probably be empty

@JasonN3
Copy link
Owner

JasonN3 commented Mar 15, 2024

Still works even with that list of flatpaks

@noelmiller
Copy link
Collaborator Author

That might be what happened. I'll try again when I'm home. Internet has been really bad here.

@JasonN3 JasonN3 added question Further information is requested and removed bug Something isn't working help wanted Extra attention is needed labels Mar 15, 2024
@JasonN3
Copy link
Owner

JasonN3 commented Mar 15, 2024

That might be what happened. I'll try again when I'm home. Internet has been really bad here.

I'll leave this open so you can confirm it works. Once you do, please close this issue

@noelmiller
Copy link
Collaborator Author

Update: Built an updated ISO in Github, downloaded it, installed, and got the same error. Did it again, and did not get the error. It is very hit or miss on when it happens. I'm so confused by this issue, it's driving me crazy.

@JasonN3
Copy link
Owner

JasonN3 commented Mar 16, 2024

Update: Built an updated ISO in Github, downloaded it, installed, and got the same error. Did it again, and did not get the error. It is very hit or miss on when it happens. I'm so confused by this issue, it's driving me crazy.

Do you have a link to the GH run that built a failed ISO so I can look through the log? And when you said you "did it again", did you run the same ISO or did you rebuild the ISO?

@noelmiller
Copy link
Collaborator Author

noelmiller commented Mar 16, 2024

Update: Built an updated ISO in Github, downloaded it, installed, and got the same error. Did it again, and did not get the error. It is very hit or miss on when it happens. I'm so confused by this issue, it's driving me crazy.

Do you have a link to the GH run that built a failed ISO so I can look through the log? And when you said you "did it again", did you run the same ISO or did you rebuild the ISO?

I thought I linked the GH run, sorry about that. https://github.com/ublue-os/bluefin/actions/runs/8305702296/job/22732901460

I used this same ISO more than once. One time it failed copying over the GPG key and it was just an empty file, tested it 2 more times and couldn't get it to fail to copy the GPG key again.

@JasonN3
Copy link
Owner

JasonN3 commented Mar 16, 2024

If it's the same ISO, then there isn't something wrong with the build process. The installation process just needs to be able to find the flatpak repo in a known location. This is the entire script: https://github.com/JasonN3/build-container-installer/blob/main/lorax_templates/scripts/post/flatpak_configure
If you get it to fail again, try to grab the anaconda logs. It might show what failed during the installation.

@JasonN3 JasonN3 added the can't duplicate Bugs that can't be consistently duplicated label Mar 16, 2024
@noelmiller
Copy link
Collaborator Author

noelmiller commented Mar 16, 2024

If it's the same ISO, then there isn't something wrong with the build process. The installation process just needs to be able to find the flatpak repo in a known location. This is the entire script: https://github.com/JasonN3/build-container-installer/blob/main/lorax_templates/scripts/post/flatpak_configure
If you get it to fail again, try to grab the anaconda logs. It might show what failed during the installation.

Yeah, I'll keep messing with it and pull logs. It's frustrating I can't get it to reproduce the issue now. I had another person try it with a brand new ISO generated using docker and no issue with that ISO installation either.

Worst case, if someone does have a broken GPG key, it's a fairly trivial fix.

@noelmiller
Copy link
Collaborator Author

Closing this, I have not been able to duplicate it for quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can't duplicate Bugs that can't be consistently duplicated question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants