Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider not moving to the right with "blocksPerView: y, movesPerClick: y" #12

Closed
macure opened this issue Feb 13, 2019 · 2 comments
Closed
Assignees
Labels
bug Something isn't working released

Comments

@macure
Copy link

macure commented Feb 13, 2019

Slider doesn't move right when:

  • Total slides = 5
  • "blocksPerView" = 3
  • "movesPerClick" = 3
  • Click "Right"

However when I click "Left" it moves from right to left, just like it should when you click "Move"

Here is the test code that I used

<jp-slider [options]="{ blocksPerView: 3, movesPerClick: 3 }">
  <jp-slides>
    <jp-slide>
      <h1>Slide 1</h1>
      <p>Content 1</p>
    </jp-slide>
    <jp-slide>
      <h1>Slide 2</h1>
      <p>Content 2</p>
    </jp-slide>
    <jp-slide>
      <h1>Slide 3</h1>
      <p>Content 3</p>
    </jp-slide>
    <jp-slide>
      <h1>Slide 4</h1>
      <p>Content 4</p>
    </jp-slide>
    <jp-slide>
      <h1>Slide 5</h1>
      <p>Content 5</p>
    </jp-slide>
  </jp-slides>
  <jp-slide-pagination></jp-slide-pagination>
  <button jpSlideArrow="left">Left</button>
  <button jpSlideArrow="right">Right</button>
</jp-slider>

Other issue:

<jp-slider [options]="{ blocksPerView: 2, movesPerClick: 2 }">

Slide 5 is never visible, when clicking "Right", multiple times, over a loop

Otherwise, really nice and simple slider. Thx

@flauc
Copy link
Member

flauc commented Feb 13, 2019

@macure thank you for reporting this 👍 . We'll look into it as soon as possible.

@flauc flauc added the bug Something isn't working label Feb 13, 2019
makiJS pushed a commit that referenced this issue Feb 20, 2019
flauc pushed a commit that referenced this issue Feb 20, 2019
## [1.6.4](v1.6.3...v1.6.4) (2019-02-20)

### Bug Fixes

* moves per click count edge case [#12](#12) ([bb108e4](bb108e4))
@flauc flauc closed this as completed Feb 20, 2019
flauc pushed a commit that referenced this issue Mar 1, 2019
## [1.6.6](v1.6.5...v1.6.6) (2019-03-01)

### Bug Fixes

* slideInView emitting with pagination closes:[#12](#12) ([95760ec](95760ec))
@flauc
Copy link
Member

flauc commented Mar 1, 2019

🎉 This issue has been resolved in version 1.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@flauc flauc added the released label Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

3 participants