From 00d84f496df81da4a006187c9c7ccbc78e98d097 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9verin=20Beauvais?= Date: Wed, 27 Dec 2023 12:07:20 -0800 Subject: [PATCH] - app version = 5.6.19 (#600) - imported updated shared correct-name and mixins - updated some validations - updated misc whitespace - added additional options to ResultingBusinessName.vue - added additional option to NameRequestInfo.vue - fixed numbered company suffix - added conditional links to return to proper steps - updated save/resume name options - updated more validations - temporarily skipped some unit tests - misc cleanup Co-authored-by: Severin Beauvais --- package-lock.json | 22 ++-- package.json | 6 +- src/App.vue | 6 + .../Amalgamation/AmalgamatingBusinesses.vue | 2 +- src/components/Amalgamation/BusinessTable.vue | 6 +- .../Amalgamation/ResultingBusinessName.vue | 37 +++--- src/components/Restoration/BusinessName.vue | 2 +- src/components/common/AddNameTranslation.vue | 1 + src/components/common/NameRequestInfo.vue | 118 +++++++++++++----- src/components/common/NameTranslations.vue | 4 +- src/components/common/Stepper.vue | 4 +- .../common/SummaryDefineCompany.vue | 48 +++++-- src/mixins/amalgamation-mixin.ts | 14 ++- src/mixins/filing-template-mixin.ts | 52 ++++++-- src/store/store.ts | 13 +- src/views/AmalgamationRegular/Information.vue | 19 --- .../IncorporationDefineCompany.vue | 5 +- .../Restoration/RestorationBusinessName.vue | 5 +- tests/unit/NameRequestInfo.spec.ts | 16 ++- 19 files changed, 246 insertions(+), 134 deletions(-) diff --git a/package-lock.json b/package-lock.json index f0d8eed13..f1782f8fd 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-create-ui", - "version": "5.6.18", + "version": "5.6.19", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "business-create-ui", - "version": "5.6.18", + "version": "5.6.19", "dependencies": { "@babel/compat-data": "^7.21.5", "@bcrs-shared-components/approval-type": "1.0.19", @@ -18,7 +18,7 @@ "@bcrs-shared-components/confirm-dialog": "1.2.1", "@bcrs-shared-components/contact-info": "1.2.15", "@bcrs-shared-components/corp-type-module": "1.0.11", - "@bcrs-shared-components/correct-name": "1.0.33", + "@bcrs-shared-components/correct-name": "1.0.36", "@bcrs-shared-components/court-order-poa": "3.0.11", "@bcrs-shared-components/date-picker": "1.2.15", "@bcrs-shared-components/document-delivery": "1.2.0", @@ -30,7 +30,7 @@ "@bcrs-shared-components/interfaces": "1.1.5", "@bcrs-shared-components/jurisdiction": "1.0.1", "@bcrs-shared-components/limited-restoration-panel": "1.0.5", - "@bcrs-shared-components/mixins": "1.1.33", + "@bcrs-shared-components/mixins": "1.1.34", "@bcrs-shared-components/nature-of-business": "1.2.14", "@bcrs-shared-components/relationships-panel": "1.0.9", "@bcrs-shared-components/staff-comments": "1.3.15", @@ -326,15 +326,15 @@ "integrity": "sha512-+iE3qiySSafiA311m14DuoG9Rq/ranBJNT7Kf7KQ9dJFDNNuTA326pCGwKBeuT1L6pFpGeibXGE+vQ0AYnSPUA==" }, "node_modules/@bcrs-shared-components/correct-name": { - "version": "1.0.33", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/correct-name/-/correct-name-1.0.33.tgz", - "integrity": "sha512-7BsHUQHkmARVAn4Vjw/3EqK+9oCKkCc54p6mlfP49PSmc55Nw4lXDd5aIvvLBDE80snvrVM/AwzJcmC/5dBz+g==", + "version": "1.0.36", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/correct-name/-/correct-name-1.0.36.tgz", + "integrity": "sha512-IQZgdcKbIR9111y/8zXfwvFv+EpXqP4YPlGErWkQofGsp42HjRefcTcLpSV2tcAkaDoqmZiGiP7w+QefxI4TmA==", "dependencies": { "@bcrs-shared-components/confirm-dialog": "^1.2.3", "@bcrs-shared-components/corp-type-module": "^1.0.14", "@bcrs-shared-components/enums": "^1.1.5", "@bcrs-shared-components/interfaces": "^1.1.5", - "@bcrs-shared-components/mixins": "^1.1.33", + "@bcrs-shared-components/mixins": "^1.1.34", "@bcrs-shared-components/types": "^1.0.1", "vue": "^2.7.14" } @@ -468,9 +468,9 @@ } }, "node_modules/@bcrs-shared-components/mixins": { - "version": "1.1.33", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/mixins/-/mixins-1.1.33.tgz", - "integrity": "sha512-Pp9mkB5s63zrADcosO3EDnYwkeV4Al6EYeYeRSTqWO7SgPqReBx2I9sMygemz/VWig0uxdtiBibYnPtf9jpcPA==", + "version": "1.1.34", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/mixins/-/mixins-1.1.34.tgz", + "integrity": "sha512-KrccSKhOthyNA9qzl++0RfeURjyq5aJutY+tiHzYB+SqrOmZ5JYvU54p/hvxti/R9RgwFLZQaERaGeIdWWpvsg==", "dependencies": { "@bcrs-shared-components/enums": "^1.1.5", "@bcrs-shared-components/interfaces": "^1.1.5", diff --git a/package.json b/package.json index 3317870a5..ed648f6d5 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-create-ui", - "version": "5.6.18", + "version": "5.6.19", "private": true, "appName": "Create UI", "sbcName": "SBC Common Components", @@ -23,7 +23,7 @@ "@bcrs-shared-components/confirm-dialog": "1.2.1", "@bcrs-shared-components/contact-info": "1.2.15", "@bcrs-shared-components/corp-type-module": "1.0.11", - "@bcrs-shared-components/correct-name": "1.0.33", + "@bcrs-shared-components/correct-name": "1.0.36", "@bcrs-shared-components/court-order-poa": "3.0.11", "@bcrs-shared-components/date-picker": "1.2.15", "@bcrs-shared-components/document-delivery": "1.2.0", @@ -35,7 +35,7 @@ "@bcrs-shared-components/interfaces": "1.1.5", "@bcrs-shared-components/jurisdiction": "1.0.1", "@bcrs-shared-components/limited-restoration-panel": "1.0.5", - "@bcrs-shared-components/mixins": "1.1.33", + "@bcrs-shared-components/mixins": "1.1.34", "@bcrs-shared-components/nature-of-business": "1.2.14", "@bcrs-shared-components/relationships-panel": "1.0.9", "@bcrs-shared-components/staff-comments": "1.3.15", diff --git a/src/App.vue b/src/App.vue index e43fa6e62..5097babb8 100644 --- a/src/App.vue +++ b/src/App.vue @@ -946,6 +946,12 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi this.nameRequestInvalidErrorDialog = true }) + // + // The NR checks below are sort-of a duplicate of code in BusinessName.vue and + // ResultingBusinessName.vue, but we assume the other checks passed if the user + // was able to add the NR to this filing, so these checks should be sufficient. + // + // ensure NR was found if (!nrResponse) { this.nameRequestInvalidType = NameRequestStates.NOT_FOUND diff --git a/src/components/Amalgamation/AmalgamatingBusinesses.vue b/src/components/Amalgamation/AmalgamatingBusinesses.vue index ee633a13b..7590b9a53 100644 --- a/src/components/Amalgamation/AmalgamatingBusinesses.vue +++ b/src/components/Amalgamation/AmalgamatingBusinesses.vue @@ -260,7 +260,7 @@ export default class AmalgamatingBusinesses extends Mixins(AmalgamationMixin, Co /** Called when Jurisdiction menu item is changed. */ onJurisdictionChange (jurisdiction: any): void { this.jurisdiction = jurisdiction - this.isCan = jurisdiction.group === 0 + this.isCan = (jurisdiction.group === 0) this.jurisdictionErrorMessage = this.jurisdiction ? '' : 'Home jurisdiction is required' this.isMrasJurisdiction = MrasJurisdictions.includes( this.jurisdiction.text.toLowerCase() diff --git a/src/components/Amalgamation/BusinessTable.vue b/src/components/Amalgamation/BusinessTable.vue index bd5c6be12..d8b5d983f 100644 --- a/src/components/Amalgamation/BusinessTable.vue +++ b/src/components/Amalgamation/BusinessTable.vue @@ -99,7 +99,6 @@ export default class BusinessTable extends Mixins(AmalgamationMixin) { readonly AmlTypes = AmlTypes readonly GetCorpFullDescription = GetCorpFullDescription - @Action(useStore) setDefineCompanyStepValidity!: (x: boolean) => void @Action(useStore) spliceAmalgamatingBusiness!: (x: number) => void /** @@ -173,7 +172,10 @@ export default class BusinessTable extends Mixins(AmalgamationMixin) { @Watch('businesses', { deep: true, immediate: true }) @Emit('valid') private emitValidity (): boolean { - return this.businesses.every(business => business.status === AmlStatuses.OK) + return ( + (this.businesses.length > 0) && + this.businesses.every(business => business.status === AmlStatuses.OK) + ) } } diff --git a/src/components/Amalgamation/ResultingBusinessName.vue b/src/components/Amalgamation/ResultingBusinessName.vue index 6eb9f7d30..843dd408d 100644 --- a/src/components/Amalgamation/ResultingBusinessName.vue +++ b/src/components/Amalgamation/ResultingBusinessName.vue @@ -5,7 +5,7 @@ >
@@ -27,6 +27,7 @@ >