Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new world loading functionality for carla #604

Open
Rhythmbellic opened this issue Mar 30, 2023 · 6 comments
Open

Add new world loading functionality for carla #604

Rhythmbellic opened this issue Mar 30, 2023 · 6 comments

Comments

@Rhythmbellic
Copy link

The app is crashing again and again when I am trying to load the inbuilt simulation and also it don't have option for loading a new simulation pls help.
https://user-images.githubusercontent.com/92723976/228941101-7ef019a6-3b95-49c9-8631-5d03f851d2ff.mp4

@sergiopaniego
Copy link
Member

Thanks for opening the issue. The issue is related to loading another world. Since the project started with support for Gazebo and then we added CARLA, some functionalities are still not ported to CARLA. The functionality for loading a new world is not yet available for CARLA.
It would be a nice issue to cover with a pull request. Would you like to work on it?

@Rhythmbellic
Copy link
Author

Sure I will go through both carla driver. Py and gazebo carla. Py for reference is any other hint you want to give before start working on this issue?

@sergiopaniego
Copy link
Member

Since this issue is also related with the application GUI, you should review the ui folder. We use PyQt5 for the GUI so it’s probably a good idea checking out its documentation If you haven’t already worked with that technology

@Rhythmbellic Rhythmbellic changed the title app crashing while loading the simulation Add new world loading functionality for carla Mar 31, 2023
@Rhythmbellic
Copy link
Author

hey @sergiopaniego I have a query, I have learned pyqt5 and gone through the GUI files right now the brain is launching from the carla ros bridge launch file and looking for the solution but I got a new issue, currently our app launch world from ros bridge file, shouldn't we load the world launch files from config folder?

@Rhythmbellic
Copy link
Author

Rhythmbellic commented Apr 8, 2023

just tell me so i can set the path as our problem have 3 changes according to me

  • Create a Carla template launch file and carla world launch file

  • Modify the world_selection.py file in the BehaviorMetrics module to include the load_carla_world function and modify the load_world function to use it if the simulator selected by the user is "Carla".

  • update the file directory in world.json

@sergiopaniego
Copy link
Member

Hi @Rhythmbellic!

We use CARLA ROS Bridge because we provide support to Gazebo too and the application structure follows the same procedures for both simulators (Gazebo uses ROS too), so we need to launch the world using the current pipeline.
The load world functionality should follow a similar approach.

I hope this answers your query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants