Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement autoLoad={false} in Select.Async #1216

Closed
f0urfingeredfish opened this issue Sep 13, 2016 · 2 comments
Closed

Implement autoLoad={false} in Select.Async #1216

f0urfingeredfish opened this issue Sep 13, 2016 · 2 comments

Comments

@f0urfingeredfish
Copy link

In the current documentation autoLoad={false} is listed as an option to stop the Async Select from loading when the component mounts.
https://github.com/JedWatson/react-select#async-options

This isn't currently implemented.
Look at:
https://github.com/JedWatson/react-select/blob/master/src/Async.js#L82

FIX:
Add autoLoad as an option with a default of true.
Check autoLoad on componentDidMount to determine if it should fetch.
@bvaughn bvaughn mentioned this issue Sep 18, 2016
Merged
@bvaughn
Copy link
Collaborator

bvaughn commented Sep 18, 2016

FYI I am working on a refactor for Async that should address this issue. (See PR #1226)

@bvaughn
Copy link
Collaborator

bvaughn commented Sep 18, 2016

Resolved via PR #1226.

Look for an RC2 to come out (hopefully) sometime today with this change.

@bvaughn bvaughn closed this as completed Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvaughn @f0urfingeredfish