Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call user-defined onInputChange props on Async and Creatable components #1231

Closed
wants to merge 5 commits into from

Conversation

ingro
Copy link

@ingro ingro commented Sep 20, 2016

This should be more consistent with the basic Select.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.779% when pulling 152cfd5 on ingro:master into 2b14448 on JedWatson:master.

@maxim-smotrov
Copy link

@ingro: Are you going to fix this PR? Otherwise I'd create my own since the community needs these changes =)

@ingro
Copy link
Author

ingro commented Oct 3, 2016

@maxim-smotrov Sorry I didn't receive any response before, what's missing? Tests I guess?

@maxim-smotrov
Copy link

@ingro: Yep, seems so

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.627% when pulling 74a1743 on ingro:master into b3db918 on JedWatson:master.

@ingro
Copy link
Author

ingro commented Oct 3, 2016

@maxim-smotrov done!

@maxim-smotrov
Copy link

maxim-smotrov commented Oct 3, 2016

Thanks @ingro!
@JedWatson, @bvaughn: Can you check this and merge please? We really need that :)

@takashi
Copy link

takashi commented Dec 7, 2016

@ingro @JedWatson @bvaughn Any updates of this PR? I'm suffering with this problem and now im using forked repo of react-select to fix this

@gwyneplaine
Copy link
Collaborator

thanks for this @ingro, this has been resolved in #2057 which has been merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants