From 30074e0401b6ab13ef8b615b42d93fb90983144b Mon Sep 17 00:00:00 2001 From: Daniel Cousens <413395+dcousens@users.noreply.github.com> Date: Mon, 7 Nov 2022 10:01:13 +1100 Subject: [PATCH 1/4] update CONTRIBUTING --- CONTRIBUTING.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0a358bb0a9..92859d0090 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,8 +18,7 @@ Before you open a PR: know. We'll help you get started, rather than inadvertently doubling up on your hard work. - Make sure you do not add regressions by running `yarn test`. - Where possible, include tests with your changes, either that demonstrates the - bug, or tests the new functionality. If you're not sure how to test your - changes, feel free to ping @gwyneplaine -- Please [follow our established coding conventions](https://github.com/keystonejs/keystone/wiki/Coding-Standards) + bug, or tests the new functionality +- Please [follow our contributors guidelines]([https://github.com/keystonejs/keystone/wiki/Coding-Standard](https://github.com/JedWatson/react-select/blob/master/CONTRIBUTING.md)) (with regards to formatting, etc) - All new features and changes need documentation. From b317f55891a40cfbe190a4b5b0b821ad7176eb2c Mon Sep 17 00:00:00 2001 From: Daniel Cousens <413395+dcousens@users.noreply.github.com> Date: Mon, 7 Nov 2022 10:06:01 +1100 Subject: [PATCH 2/4] add punctuation --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 92859d0090..8afb5a04b4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,7 +18,7 @@ Before you open a PR: know. We'll help you get started, rather than inadvertently doubling up on your hard work. - Make sure you do not add regressions by running `yarn test`. - Where possible, include tests with your changes, either that demonstrates the - bug, or tests the new functionality -- Please [follow our contributors guidelines]([https://github.com/keystonejs/keystone/wiki/Coding-Standard](https://github.com/JedWatson/react-select/blob/master/CONTRIBUTING.md)) + bug, or tests the new functionality. +- Please [follow our contributors guidelines]([https://github.com/keystonejs/keystone/wiki/Coding-Standard](https://github.com/JedWatson/react-select/blob/master/CONTRIBUTING.md)). (with regards to formatting, etc) - All new features and changes need documentation. From b222366abc5153f9b9fba56b5d96258a8c745f59 Mon Sep 17 00:00:00 2001 From: Daniel Cousens <413395+dcousens@users.noreply.github.com> Date: Mon, 7 Nov 2022 10:20:14 +1100 Subject: [PATCH 3/4] Fix link --- CONTRIBUTING.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8afb5a04b4..8a7f5f3665 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,6 +19,5 @@ Before you open a PR: - Make sure you do not add regressions by running `yarn test`. - Where possible, include tests with your changes, either that demonstrates the bug, or tests the new functionality. -- Please [follow our contributors guidelines]([https://github.com/keystonejs/keystone/wiki/Coding-Standard](https://github.com/JedWatson/react-select/blob/master/CONTRIBUTING.md)). - (with regards to formatting, etc) +- Please [follow our contributors guidelines](https://github.com/JedWatson/react-select/blob/master/CONTRIBUTING.md). - All new features and changes need documentation. From f9aed53e307a5d98d3fdc0ac74aab9d79a4cbfdb Mon Sep 17 00:00:00 2001 From: Daniel Cousens <413395+dcousens@users.noreply.github.com> Date: Mon, 7 Nov 2022 23:03:34 +1100 Subject: [PATCH 4/4] remove circular reference --- CONTRIBUTING.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8a7f5f3665..e8a43d8534 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,5 +19,4 @@ Before you open a PR: - Make sure you do not add regressions by running `yarn test`. - Where possible, include tests with your changes, either that demonstrates the bug, or tests the new functionality. -- Please [follow our contributors guidelines](https://github.com/JedWatson/react-select/blob/master/CONTRIBUTING.md). - All new features and changes need documentation.