Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate parameter malfunctions when there are also shape parameters #3

Closed
JelleAalbers opened this issue Aug 19, 2016 · 0 comments · Fixed by #4
Closed

Rate parameter malfunctions when there are also shape parameters #3

JelleAalbers opened this issue Aug 19, 2016 · 0 comments · Fixed by #4
Labels

Comments

@JelleAalbers
Copy link
Owner

The implementation for rate parameters assumes the fraction of events that fall in the analysis space is the same for every model. This is not true when there are shape parameters.

A related problem exists for rate uncertainties (rate parameters with a prior). The prior is currently defined over the absolute rate, but this is affected by shape parameters too.

I'm going to switch rate parameters to be multipliers of the rate get out of this mess. This will mean a few examples in laidbax have to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant