Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GlobalMaxPool3D layer #117

Closed
mkaze opened this issue Jun 15, 2021 · 1 comment · Fixed by #130
Closed

Add GlobalMaxPool3D layer #117

mkaze opened this issue Jun 15, 2021 · 1 comment · Fixed by #130
Assignees
Milestone

Comments

@mkaze
Copy link
Contributor

mkaze commented Jun 15, 2021

Currently, the support for GlobalMaxPool3D is missing and it would be great if we could add support for this layer as well. The desired PR addressing this issue should include:

  • Implementation of layer class named as GlobalMaxPool3D (you can take inspiration from implementation of GlobalMaxPool1D as reference)
  • Documentation of layer.
  • Test cases
  • Support for export of layer to JSON (see ModelSaver.kt)
  • Support for import of layer from JSON (see ModelLoader.kt)

Also, if needed, you can take a look at Keras documentation for this layer. NOTE: for the moment, there is no need to add support for "data format" (i.e. channels last vs. channels first) in your PR; you can simply assume the channels are always in the last dimension.

@zaleslaw
Copy link
Collaborator

So, are you going to create PR by yourself or we will mark it with the "good first issue"?

@mkaze mkaze mentioned this issue Jun 16, 2021
4 tasks
@zaleslaw zaleslaw added this to the 0.3 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants