Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cropping1D and Cropping3D layers #121

Closed
7 tasks
zaleslaw opened this issue Jun 15, 2021 · 1 comment · Fixed by #141
Closed
7 tasks

Add Cropping1D and Cropping3D layers #121

zaleslaw opened this issue Jun 15, 2021 · 1 comment · Fixed by #141
Assignees
Labels
good second issue Good for advanced contributors
Milestone

Comments

@zaleslaw
Copy link
Collaborator

zaleslaw commented Jun 15, 2021

Currently, the support for Cropping1D and Cropping3D are missed, and it would be great if we could add support for these layers. The desired PR addressing this issue should include:

  • Implementation of layer class named as Cropping1D (you can take inspiration from the implementation of Cropping2D as reference)
  • Implementation of layer class named as Cropping3D (you can take inspiration from the implementation of Cropping2D as reference)
  • Common hierarchy of all Cropping layers with abstract cropping class with the common functionality
  • Documentation of layer and all non-private methods
  • JUnit tests in api module
  • Support for export of layer to JSON (see ModelSaver.kt)
  • Support for import of layer from JSON (see ModelLoader.kt)

Also, if needed, you can take a look at Keras documentation for Cropping1D and Cropping3D.

NOTE: for the moment, there is no need to add support for "data format" (i.e., channels last vs. channels first) in your PR; you can assume the channels are always in the last dimension.

P.S. If you want to take this ticket, please leave the comment below
P.P.S Read the Contributing Guidelines.

@zaleslaw zaleslaw added the good second issue Good for advanced contributors label Jun 15, 2021
@zaleslaw zaleslaw added this to the 0.3 milestone Jun 15, 2021
@mkaze
Copy link
Contributor

mkaze commented Jun 17, 2021

I'll take this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good second issue Good for advanced contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants