You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@juliabeliaeva I merged the #225 .
It will be really helpful to get this patch or PR, but I'm a little bit confused about this separator (I've tested the 0.1 and 0.2 release on Ubuntu and macOS and it seems to work fine on both of them with the same separator).
But I don't test all examples and tests and for example, Cifar10 too. On another side, all examples run a lot of times on TC on Ubuntu and macOS successfully.
Looks like I need to include in the required pre-release testing procedure manually running of all examples on different TC
P.S. I remember this problem with separators a few years ago when I was working on a project which used a file system a lot of the time and it supports multiple filesystems, so I used different separators for each of them.
P.P.S I recognized that Cifar10Util contains unused code (outdated special loaders for Cifar10 dataset), this is a reason why it's not raised during TC runs (with high level probability I'll remove it in two days)
Save preprocessor works with windows separators, it just saves the file in the wrong place and I guess this is not tested. As for Cifar10Util, yes, the code is unused.
How about fix this line with
File.separator
? This is not correct for unix systems now.Originally posted by @YokiToki in #209 (comment)
The text was updated successfully, but these errors were encountered: