-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert functions to properties in public API #29
Comments
@quickstep24 agree, with this change to be more Kotlin-idiomatic. If you want, you could create a PR for this and same cases |
I would like to do this, but I have a question: Should this be done while keeping and deprecating the existing |
And the next question: Structural search revealed things like: |
@LostMekka no worry about deprecation, feel free to remove methods and convert to properties. But I'm not sure about getWeigths - the idea was to have an abstract method that should be overridden in each layer and sometimes it has a very large body. Maybe you have any idea about renaming this method? |
I'm not sure there either. How about fetchWeights, readWeights, or maybe extractWeights? I don't feel very competent in this particular domain, so I don't know which word would fit best. 😅 |
* changed Optimizer.getOptimizerName into a property * changed Optimizer.isRunningOnGPU into a property * changed Layer.getParams and Layer.hasActivation into a properties * renamed Layer.getWeights to extractWeights * converted getKernelShape and getBiasShape to properties * converted Layer.extractWeights to property also cleaned up weights code for Dense and Conv2D
Convert function to property
public abstract fun getOptimizerName(): String
=>
public abstract val optimizerName: String
in
Optimimizer.kt
The text was updated successfully, but these errors were encountered: