Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Orthogonal initializer #51

Closed
zaleslaw opened this issue May 18, 2021 · 3 comments · Fixed by #84
Closed

Add Orthogonal initializer #51

zaleslaw opened this issue May 18, 2021 · 3 comments · Fixed by #84
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@zaleslaw
Copy link
Collaborator

zaleslaw commented May 18, 2021

We are missing some initializers to fully support the export of models from Keras. One of them is the Orthogonal initializer.

Add an initializer class, write documentation for it, write a test for it, try, if possible, create a small trainable network with it (in your own GitHub) and attach a link.

Also, support for export and import of initializer in JSON format should be added (see ModelLoader.kt and ModelSaver.kt)

A detailed description of the initializer can be found here

@zaleslaw zaleslaw added the good first issue Good for newcomers label May 18, 2021
@zaleslaw zaleslaw added this to the 0.3 milestone May 18, 2021
@zaleslaw
Copy link
Collaborator Author

zaleslaw commented Jun 1, 2021

@therealansh, please leave a comment here, to assign this issue on you

@therealansh
Copy link
Contributor

Oh sorry @zaleslaw ! Might have missed on this one. I'll be completing the tests soon and finalising the PR.

@zaleslaw zaleslaw linked a pull request Jun 9, 2021 that will close this issue
4 tasks
@zaleslaw
Copy link
Collaborator Author

zaleslaw commented Jun 9, 2021

Fixed in #84

@zaleslaw zaleslaw closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants