Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Add Conv1D layer #59

Closed
zaleslaw opened this issue May 18, 2021 · 2 comments · Fixed by #67
Closed

[Audio] Add Conv1D layer #59

zaleslaw opened this issue May 18, 2021 · 2 comments · Fixed by #67
Assignees
Labels
good second issue Good for advanced contributors
Milestone

Comments

@zaleslaw
Copy link
Collaborator

zaleslaw commented May 18, 2021

We are missing some layers to support the export of models from Keras fully. One of them is the Conv1D layer.

Add a layer class, write documentation for it, write a test for it, try, if possible, create a small trainable network with it (in your own GitHub) and attach a link here in the comments.

The layer should be placed here

As a reference implementation, the Conv2D layer could be used, but feel free to improve it!

If some refactoring to convolutional layers could be applied, please, try to do it!

Also, support for export and import of layer in JSON format should be added (see ModelLoader.kt and ModelSaver.kt)

A detailed description of the layer can be found here

P.S. There are no-ops for tf.nn.conv1d in Java API, so you could try to implement it from scratch via available ops or use tf.nn.conv2d like in TensorFlowJS with reshape in tfjs-core/src/ops/conv1d.ts

@zaleslaw zaleslaw added the good first issue Good for newcomers label May 18, 2021
@zaleslaw zaleslaw added this to the 0.3 milestone May 18, 2021
@zaleslaw zaleslaw changed the title Add Conv1D layer [Audio] Add Conv1D layer May 18, 2021
@avan1235
Copy link
Contributor

I can start working on it on my repository fork and try to open PR in a few days

@zaleslaw
Copy link
Collaborator Author

Great, @avan1235 I could assign the ticket if you are in the comments thread

@zaleslaw zaleslaw added good second issue Good for advanced contributors and removed good first issue Good for newcomers labels May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good second issue Good for advanced contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants