-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text looks bad in Windows 10 #875
Comments
Text in Compose for Desktop is rendered without subpixel anti-aliasing for now. The issue is known and blocked by the issue in skia (another one) P.S.
|
Thanks for that information, it's good that the cause is known! I feel like I'm always having this issue whenever a new multiplatform-framework targets windows. I remember similar issues when Electron was new, and Qt also has issues unless you manually mess with text rendering. I know that a lot of devs use Macs nowadays, but a majority of consumers are still using Windows as far as I am aware--especially in the scientific and engineering (my area) communities where desktop apps are still the primary means of doing work. |
By the way, there is a way to draw a text with subpixel antialiasing, if we use Canvas directly:
|
Fixes JetBrains/compose-multiplatform#875 TODO: read clear type settings on skiko level from system. The same way as Chromium does it: https://source.chromium.org/chromium/chromium/src/+/main:ui/gfx/font_render_params_win.cc;l=91;drc=2d80b7b69c11da0716326b7fdc15568fc30820c2 Also we need to observe changes, and recreate surface in Skiko when pixel geometry changes (it happens, when the user rotates the display/tablet)
Thanks, this is huge 🎉 It basically opens up Compose Desktop for use on Windows! |
It seems GitHub closed it somehow, even it is not merged yet. It wasn't meant to be closed, so reopening, until we merge all functionality (it won't be in 1.2.0) |
Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks. |
Text seems to look poorly rendered in Windows 10. I opened the Code Viewer example and just immediately thought the text looks off. Maybe it's not applying subpixel anti-aliasing, but I'm really not sure. The text looks too sharp and kinda jagged.
And I don't think its only this example. Ever since I started testing Compose Desktop I thought the text just didn't look quite right.
The text was updated successfully, but these errors were encountered: