fix: show better internal server error

JimmyLv · Mar 13, 2023 · 62bc2aa · 62bc2aa · vercel · Mar 13, 2023
1 parent dda1ef6
commit 62bc2aa
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 9 deletions.
diff --git a/hooks/useSummarize.ts b/hooks/useSummarize.ts
@@ -3,7 +3,10 @@ import { useToast } from "~/hooks/use-toast";
 import { UserConfig, VideoConfig } from "~/lib/types";
 import { RATE_LIMIT_COUNT } from "~/utils/constants";
 
-export function useSummarize(showSingIn: (show: boolean) => void, enableStream: boolean = true) {
+export function useSummarize(
+  showSingIn: (show: boolean) => void,
+  enableStream: boolean = true
+) {
   const [loading, setLoading] = useState(false);
   const [summary, setSummary] = useState<string>("");
   const { toast } = useToast();
@@ -59,11 +62,12 @@ export function useSummarize(showSingIn: (show: boolean) => void, enableStream:
           });
           showSingIn(true);
         } else {
+          const errorJson = await response.json();
           toast({
             variant: "destructive",
-            title: response.statusText,
+            title: response.status + " " + response.statusText,
             // ReadableStream can't get error message
-            // description: response.body
+            description: errorJson.errorMessage,
           });
         }
         setLoading(false);

diff --git a/lib/openai/fetchOpenAIResult.ts b/lib/openai/fetchOpenAIResult.ts
@@ -50,7 +50,8 @@ export async function fetchOpenAIResult(
   });
 
   if (res.status !== 200) {
-    throw new Error("OpenAI API: " + res.statusText);
+    const errorJson = await res.json();
+    throw new Error(`OpenAI API Error [${res.statusText}]: ${errorJson.error?.message}`);
   }
 
   const { showTimestamp, videoId } = videoConfig;

diff --git a/pages/api/sumup.ts b/pages/api/sumup.ts
@@ -86,16 +86,25 @@ export default async function handler(
       userKey,
       videoId
     );
-    const result = await fetchOpenAIResult(openAiPayload, openaiApiKey, videoConfig);
+    const result = await fetchOpenAIResult(
+      openAiPayload,
+      openaiApiKey,
+      videoConfig
+    );
     if (stream) {
       return new Response(result);
     }
 
     return NextResponse.json(result);
   } catch (error: any) {
-    console.error("API error", error, error.message);
-    return NextResponse.json({
-      errorMessage: error.message,
-    });
+    console.error(error.message);
+    return new Response(
+      JSON.stringify({
+        errorMessage: error.message,
+      }),
+      {
+        status: 500,
+      }
+    );
   }
 }