Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Makefile code sample for tests #51

Closed
JoaoDanielRufino opened this issue Oct 13, 2022 · 7 comments · Fixed by #56
Closed

Add Makefile code sample for tests #51

JoaoDanielRufino opened this issue Oct 13, 2022 · 7 comments · Fixed by #56
Assignees
@sobczak-m @the-writer-dev
Labels
easy Easy issue good first issue Good for newcomers hacktoberfest Hacktoberfest event

Comments

@JoaoDanielRufino
Copy link
Owner

Add Makefile code samples for tests on analyzer and scanner
@JoaoDanielRufino JoaoDanielRufino added good first issue Good for newcomers hacktoberfest Hacktoberfest event easy Easy issue labels Oct 13, 2022
@sobczak-m
Copy link

Could you describe in more detail what is to be done?

make analyzer-test for run tests in pkg/analyzer and same behaviour for scanner?

@the-writer-dev
Copy link
Contributor

the-writer-dev commented Oct 14, 2022 •
edited
Loading

@JoaoDanielRufino Could you assign this to me? I love to work on this :)

@JoaoDanielRufino
Copy link
Owner Author

Could you describe in more detail what is to be done?

make analyzer-test for run tests in pkg/analyzer and same behaviour for scanner?

Look at this PR. Basically you need to add a Makefile sample code on test/fixtures/code_samples and then update analyzer_test.go and scanner_test.go

@JoaoDanielRufino
Copy link
Owner Author

JoaoDanielRufino commented Oct 14, 2022 •
edited
Loading

@JoaoDanielRufino Could you assign this to me? I love to work on this :)

I will assign you and @sobczak-m , the one who do it first will be accepted. You have 5 days to do it or I will unassign you both

@the-writer-dev
Copy link
Contributor

@JoaoDanielRufino sounds good. I will put up pr tomorrow

@the-writer-dev
Copy link
Contributor

@JoaoDanielRufino I made a pull request for this. Please review it when you have a chance!

@JoaoDanielRufino JoaoDanielRufino linked a pull request Oct 18, 2022 that will close this issue
Add makefile code sample for tests #56
Merged
@JoaoDanielRufino
Copy link
Owner Author

Close due PR #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobczak-m sobczak-m

@the-writer-dev the-writer-dev

Labels
easy Easy issue good first issue Good for newcomers hacktoberfest Hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add makefile code sample for tests the-writer-dev/gcloc
3 participants
@JoaoDanielRufino @sobczak-m @the-writer-dev