Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vue fixture. #54

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Add Vue fixture. #54

merged 1 commit into from
Oct 17, 2022

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Oct 14, 2022

Adds a trivial Vue file for #50

JoaoDanielRufino
JoaoDanielRufino requested changes Oct 14, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the vue file to scanner_test.go ?

test/fixtures/code_samples/App.vue Show resolved Hide resolved
@jmhobbs
Copy link
Contributor Author

jmhobbs commented Oct 15, 2022

Added 👍

JoaoDanielRufino
JoaoDanielRufino approved these changes Oct 17, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amazing contribution!

@JoaoDanielRufino JoaoDanielRufino added hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request labels Oct 17, 2022
@JoaoDanielRufino JoaoDanielRufino linked an issue Oct 17, 2022 that may be closed by this pull request
Add Vue code sample for tests #50
Closed
@JoaoDanielRufino JoaoDanielRufino merged commit d5fe28f into JoaoDanielRufino:master Oct 17, 2022
@jmhobbs jmhobbs deleted the add-vue-sample branch October 17, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoDanielRufino JoaoDanielRufino JoaoDanielRufino approved these changes

Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vue code sample for tests
2 participants
@jmhobbs @JoaoDanielRufino