Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace necessity argument with **kwargs #83

Open
JohannesWiesner opened this issue Apr 9, 2024 · 3 comments
Open

Replace necessity argument with **kwargs #83

JohannesWiesner opened this issue Apr 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@JohannesWiesner
Copy link
Owner

tcy currently requires the user to have a "necessity" column in the .tsv file. This was introduced primarily because the github runners did not have enough RAM in the past to solve .yml files with too many packages. However, RAM for the runners was increased in the last year. Pitching for adapting this argument, so that tcy can accept any other key-value(s) pair where the key represents a column and the value(s) represent rows that should be filtered for. This gives more flexibility to the users.

**kwargs could also be named **filter_kwargs or something

@JohannesWiesner JohannesWiesner added the enhancement New feature or request label Apr 9, 2024
@JohannesWiesner
Copy link
Owner Author

@JohannesWiesner
Copy link
Owner Author

Should be possible to do something like this

--column_name value1 value2

or

--column_name value1

The first one would mean that for this column we only want rows that have any of these values and the second one would mean that we only want to include rows where this column only has this value

@JohannesWiesner
Copy link
Owner Author

Update: See #86 . Actually it makes sense to keep an --include flag. But it also makes sense to add **filter_kwargs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant