Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Instance.fromExisting type #678

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Add Instance.fromExisting type #678

merged 3 commits into from
Jul 11, 2024

Conversation

Barocena
Copy link
Contributor

this PR adds Instance.fromExisting type

@Barocena Barocena changed the title add Instance.fromExisting type Add Instance.fromExisting type Jul 11, 2024
JohnnyMorganz
JohnnyMorganz approved these changes Jul 11, 2024
View reviewed changes
Copy link
Owner

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We might want to attach a magic function to this to provide better types

@JohnnyMorganz JohnnyMorganz merged commit 7fec4e7 into JohnnyMorganz:main Jul 11, 2024
11 checks passed
JohnnyMorganz added a commit that referenced this pull request Jul 13, 2024
@JohnnyMorganz
Attach magic function to Instance fromExisting
20caa86 
Follow up on #678
@JohnnyMorganz
Copy link
Owner

Magic function added in 20caa86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyMorganz JohnnyMorganz JohnnyMorganz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barocena @JohnnyMorganz