Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSM unit conversion #221

Open
JonKing93 opened this issue Jul 15, 2021 · 0 comments
Open

PSM unit conversion #221

JonKing93 opened this issue Jul 15, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@JonKing93
Copy link
Owner

JonKing93 commented Jul 15, 2021 •
edited
Loading

We should develop a common interface that allows PSMs to apply a unit conversion to values passed from an ensemble. This way, PSM.estimate can pass the same values from an ensemble to PSMs that require different units.
@JonKing93 JonKing93 added the enhancement New feature or request label Aug 12, 2022
@JonKing93 JonKing93 changed the title Perhaps PSMs should be responsible for converting values? PSM unit conversion Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonKing93