Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to openjfx19 and jdk17 and gradle 6.7 #76

Closed
wants to merge 2 commits into from

Conversation

Siedlerchr
Copy link

Fixes #75
Fixes #70

Superseeds #64

@credmond
Copy link

Thanks for this @Siedlerchr. A shame nobody will merge your PR.

Have you noticed less bugs with your newer build?

@Siedlerchr
Copy link
Author

Siedlerchr commented Oct 21, 2023

TBH I haven't used Scene Builder in ages. At least not recently after I made this PR.

I need to compile it locally because the mac binaries are not signed/ nor notarized. And because the gradle version was no outdated, I could event get it compiled with a newer version of Java

A shame nobody will merge your PR.

Yes, that's what sucks here with the whole javafx ecosystem. The say, look there are cool open source libraries babla however, most of them are horrible outdated and nobody even cares about PRs coming in. That sucks the most.

@credmond
Copy link

credmond commented Oct 21, 2023

TBH I haven't used Scene Builder in ages. At least not recently after I made this PR.

Well it works much better with your build. I had thought that it was just a rubbish buggy tool (couldn't understand why people said it was "essential"). I didn't think it was just JDK incompatibilities.

Yes, that's what sucks here with the whole javafx ecosystem. The say, look there are cool open source libraries babla however, most of them are horrible outdated and nobody even cares about PRs coming in. That sucks the most.

Yep -- I am coming back to JavaFX after 2014 (when I thought it was great). Back then I never used SceneBuilder or ScenicView (probably when they actually worked with minimal bugs).

I was shocked/saddended to see the state of the ecosystem. Everything was just broken: tools, documentation, links. Releasing new major versions of something with practically no fixes/improvements, and marketing them. Every JavaFX ecosystem repo has hundreds of ignored issues and PRs -- some fixing critical issues -- just sitting there. Very sad. They're all controlled by the same seemingly absent folks. I won't mention names / companies, but you know who/what I mean.

I know they're just understaffed and not making money from these libs, it's not their fault, they can't do everything. I just think the projects aren't really open source if nobody can contribute in a timely manner.

I personally am hesitant to spend any time fixing anything sizeable because I know a PR will sit there ignored for 3 years.

Maybe we should fork and publish our own packages -- very easy / free using Github Packages. Don't even need to sign them.

@JonathanGiles
Copy link
Owner

This should be fixed by #78 that was just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScenicView to be compatible with Java17 Cannot build with gradle 7.4.2 on mac m1
3 participants