Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RCS1197 #1093

Merged
merged 7 commits into from
Jun 6, 2023
Merged

Fix RCS1197 #1093

merged 7 commits into from
Jun 6, 2023

Conversation

jamesHargreaves12
Copy link
Contributor

An interpolated string can also be a verbatim string. Currently, The code fix for RCS1197 will not retain the verbatim @ when optimizing a string interpolation which means that the resulting code doesn't compile.

For example

stringBuilder.Append($@"{x:hh\:mm\:ss\.fff}"));

Becomes

stringBuilder.AppendFormat("{0:hh\:mm\:ss\.fff}",x));

jamesHargreaves12 and others added 2 commits June 4, 2023 11:57
Co-authored-by: Josef Pihrt <josef@pihrt.net>
…tringToStringBuilderMethodRefactoring.cs

Co-authored-by: Josef Pihrt <josef@pihrt.net>
@josefpihrt josefpihrt merged commit 0a33d23 into dotnet:main Jun 6, 2023
Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
Co-authored-by: Josef Pihrt <josef@pihrt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants