Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Include compiler diagnostics in the xml output file #964

Merged
merged 4 commits into from
Oct 16, 2022
Merged

[CLI] Include compiler diagnostics in the xml output file #964

merged 4 commits into from
Oct 16, 2022

Conversation

PeterKaszab
Copy link
Contributor

Fixes #963

@PeterKaszab PeterKaszab changed the title [CLI] Include compiler diagnostics in the xml output file [CLI] Include compiler diagnostics in the xml output file of the roslynator analyze command Oct 13, 2022
@PeterKaszab PeterKaszab marked this pull request as ready for review October 13, 2022 16:58
josefpihrt
josefpihrt reviewed Oct 16, 2022
View reviewed changes
ChangeLog.md Outdated Show resolved Hide resolved
@josefpihrt
Copy link
Collaborator

Hi,

thanks for the PR.

Please add yourself to the changelog (if you want).

Otherwise I'm ready to merge it.

@PeterKaszab @josefpihrt
Update ChangeLog.md
8f7c0c0 
Co-authored-by: Josef Pihrt <josef@pihrt.net>
@PeterKaszab
Copy link
Contributor Author

Hi,

thanks for the PR.

Please add yourself to the changelog (if you want).

Otherwise I'm ready to merge it.

Done.

Thank you for the review.

@josefpihrt josefpihrt changed the title [CLI] Include compiler diagnostics in the xml output file of the roslynator analyze command [CLI] Include compiler diagnostics in the xml output file Oct 16, 2022
@josefpihrt josefpihrt merged commit 4e6bb7e into dotnet:main Oct 16, 2022
@PeterKaszab PeterKaszab mentioned this pull request Mar 20, 2023
Closed
Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
@PeterKaszab @josefpihrt @JochemHarmes
[CLI] Include compiler diagnostics in the xml output file (dotnet#964)
f50240a 
Co-authored-by: Josef Pihrt <josef@pihrt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefpihrt josefpihrt josefpihrt left review comments

Assignees

@PeterKaszab PeterKaszab

Labels
Area-CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI] Include compiler diagnostics in the xml output file of the roslynator analyze command
2 participants
@PeterKaszab @josefpihrt