Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other languages #147

Open
jubuehrer opened this issue Jul 3, 2024 · 4 comments
Open

Support other languages #147

jubuehrer opened this issue Jul 3, 2024 · 4 comments

Comments

@jubuehrer
Copy link

jubuehrer commented Jul 3, 2024

At the time email-validator does not support other languages in its error messages.
This leads us to check for the error messages and then replace them with our own messages which can be translated.
This is just a hacky solution which is causing trouble, like in the newest version where some messages has changed.

We need this messages in English and German. But i think developers of other countries would love to see the error messages an their language as well :).

If needed I will assist you on this task to translate to German.

@BrentHuang
Copy link

I need Simplified Chinese, please.

As fact, we need an i18n enhancement.

@JoshData
Copy link
Owner

JoshData commented Jul 9, 2024

Thanks, ok, I'll try to work on this as I have time.

@jubuehrer
Copy link
Author

A alternative for language support would be to just use status codes instead. That way every language is (kind of) supported.

@JoshData
Copy link
Owner

JoshData commented Nov 4, 2024

Many of the messages are interpolated with specific information from the input like an invalid character code, so a status code wouldn't solve the problem.

Probably each exception should be made it's own, meaningful class. I had resisted doing that in the past but it's probably the easiest first step to eventually getting to localized messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants