Replies: 8 comments 6 replies
-
|
Yeah that's a great question! https://github.com/airbnb/ts-migrate is a great package and works really well. I think that right now, because of how early stage & buggy (🙃) TypeStat is, I'd probably recommend teams use ts-migrate over TypeStat for now. The reason why TypeStat isn't as "production ready" as ts-migrate is that it's got much larger aims as a project. ts-migrate gets you to a starting place as conveniently and quickly as possible. It suppresses type errors but doesn't do much about getting you to the best possible types. TypeStat, on the other hand, aims to do that convenient+quick work plus improving your types as much as possible. Improving types is a very difficult, even unsolvable challenge! Medium-to-long term, I think TypeStat will be more "competitive" (in a friendly, supportive sense!):
My plans for 2023 didn't start off with #1000 or #1314. I think I'm going to end up making a lot of progress on #1314 this season in service of #1318. All that is to say: yes, resolving this docs issue is part of #1314. Great question & thanks for asking! |
Beta Was this translation helpful? Give feedback.
-
|
I want to highlight that there is also this tool that I only learned about yesterday https://github.com/coderaiser/putout - it's in the same domain but exactly same as the other fixers. |
Beta Was this translation helpful? Give feedback.
-
|
@rubiesonthesky does it do anything with regards to adding a type alias for |
Beta Was this translation helpful? Give feedback.
-
|
@GitMurf Unfortunately no, I did not study what that does. 😅 I was just googling something related when squashing bugs in typestat |
Beta Was this translation helpful? Give feedback.
-
|
Love it all! I don't have any bandwidth right now to help but as soon as I get some I will be happy to try and help if I can. A couple notes, ts-migrate appears to have quite a few bugs today given it hasn't been updated in a bit and my hunch is a lot to do with TS 5.0 as well as older eslint (core part of its workflow). Things like the "satisfies" keyword is not recognized so they all get ts-ignored. And another big issue I had was JSX comments as they are not properly Also would be nice to have a more generalized (non react specific) workflow as I use solid-js for example. Additionally a real bummer is when you try to re-run ts-migrate it actually reverts a lot of manual fixes to the Jsx comments for example :( point is, there is definitely a need for what you are working on today more than ever! Even just the ts-initialize piece will be very beneficial with an updated look with ts 5+ 👍 |
Beta Was this translation helpful? Give feedback.
-
|
Curious where things sit today? We are preparing to finish off the rest of our js to ts migration by running either ts-migrate or typestat. We are doing everything net new in TS but still have all our grandfathered js code that gives us all the fun red squigglies. Our main goal is to draw a line in the sand so that we can actually add tsc type checking to our CLI and know when new errors are introduced... which we cannot do with our 600 leftover errors. Thanks as always for the amazing work in the TS community! |
Beta Was this translation helpful? Give feedback.
-
|
Things haven't changed at all since you last checked in, I'm afraid. I've put this on my list of 2024 initiatives - so you can expect something within the next ~11 months or so. ...I imagine that's probably not super helpful given you're finishing off the rest of your migration now, sorry. 😓 |
Beta Was this translation helpful? Give feedback.
-
|
@JoshuaKGoldberg I want to be mindful of abusing gh issues with stuff that doesn't belong there. Would you be open to adding gh discussions to this repo to have a place where the community can ask questions and discuss amongst ourselves any tips, tricks, learnings, problems etc.? Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Sure, just opened it up - thanks for asking! ❤️ |
Beta Was this translation helpful? Give feedback.
-
Man you're fast! Thank you good sir! |
Beta Was this translation helpful? Give feedback.
-
|
@JoshuaKGoldberg actually maybe this issue itself is a good candidate to convert to a Discussion item? I don't think I am able to do it. Thoughts? |
Beta Was this translation helpful? Give feedback.
-
|
My only gripe is that we can't thread existing comments into a single thread. 😄 |
Beta Was this translation helpful? Give feedback.
-
|
I am with you on that! There are still some quirks with gh discussions that leave me feeling like it is still a bit half baked but I prefer not to dirty up and abuse gh issues as well ;) My biggest one is I wish that it would show references / "backlinks" to other discussions and issues when linking them! That to me is still the best feature of the gh issues / pr ecosystem. |
Beta Was this translation helpful? Give feedback.
-
|
Yes! That's bit me a bunch of times, even this month. Irksome haha. |
Beta Was this translation helpful? Give feedback.
-
As the title says, I am curious on whether there is an opinion on whether TypeStat can and/or should be used together with (or instead of) ts-migrate? Do they do different things well? Or are they essentially the same type of tool?
Thanks for your amazing work as always!
Beta Was this translation helpful? Give feedback.
All reactions