feat: add getAccessKind #398
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 80.25% 79.60% -0.65%
==========================================
Files 35 36 +1
Lines 6426 6639 +213
Branches 360 437 +77
==========================================
+ Hits 5157 5285 +128
- Misses 1269 1354 +85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/nodes/access.test.ts
Outdated
There was a problem hiding this comment.
I'll add some more tests 🙂
There was a problem hiding this comment.
Added some, ran out of time+energy to add more. Can file a followup issue.
|
It would be great to have this (and through this, get |
| /** | ||
| * What operations(s), if any, an expression applies. | ||
| */ | ||
| export enum AccessKind { |
There was a problem hiding this comment.
Could it be better to express these in bitwise notation, to make it clear that's how they are supposed to be used?
export enum AccessKind {
None = 0,
Read = 1 << 0,
Write = 1 << 1,
Delete = 1 << 2,
ReadWrite = Read | Write,
}There was a problem hiding this comment.
It's probably a bit unnecessary though.
PR Checklist
status: accepting prsOverview
Adds the function, with some rudimentary unit tests.