Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotkey to select search bar #213

Closed
gjed opened this issue Oct 11, 2021 · 3 comments
Closed

Add hotkey to select search bar #213

gjed opened this issue Oct 11, 2021 · 3 comments
Milestone

Comments

@gjed
Copy link

gjed commented Oct 11, 2021

Is your feature request related to a problem? Please describe.
When there are many images if frustrating to scroll up and down the list of images. The search bar is really nice but when jumping from image to image I have to select it every time with the mouse.

Describe the solution you'd like
It would be nice to have a hotkey to select the search bar

Describe alternatives you've considered
Scroll down the list or use normal chrome ctrl+f

Additional context
I added a accesskey attribute in the dist docker-registry-ui.js as a workaround and it works nicely. I'm don't know enough of riot to put hands on the original source code.

Ps: consider to implement more keyboard navigation: it would be really nice!

@Joxit
Copy link
Owner

Joxit commented Oct 16, 2021

Hello, thank you for using my project 😄

Yes, this would be a nice addition, I was a little afraid of the compatibility of browsers to tell the truth...

What actions do you want to do using shortcuts?

@gjed
Copy link
Author

gjed commented Oct 16, 2021

Yes compatibility doesn't always workout nice!
The "accesskey" attribute is supported pretty much everywhere, but the user experience is not consistent from browser to browser.
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey

Other than the "f" shortcut for search, I'm not sure what would be nice or doable.. take it with a grain of salt.
As a story: the user navigats the registry using the keboard > shortcut "f" to filter down the images > select the images he wants form the ones left using "up/down" shortcut > press "enter" to select the one he wants to see the history/details > goes back to the main list or last search with "back" shortcut.

I see it like using the keyboard to navigate the filesystem in win explorer

Other idea completely off-topic: what about exposing prometheus-style metrics about the registry?

@Joxit Joxit closed this as completed in f958365 Nov 6, 2021
@Joxit
Copy link
Owner

Joxit commented Nov 6, 2021

Hi there,
You can now select the search bar with the shortcut CRTL + F or F3. When the search bar is already focused, the shortcut will fallback to the default behavior.

For prometheus-style metrics, you should write an issue here github.com/distribution/distribution, it's the project of the registry.

@Joxit Joxit added this to the 2.1.0 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants