Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Faraday Version Dependency #157

Closed
drock opened this issue Dec 15, 2015 · 1 comment · Fixed by #162
Closed

Incorrect Faraday Version Dependency #157

drock opened this issue Dec 15, 2015 · 1 comment · Fixed by #162

Comments

@drock
Copy link
Contributor

drock commented Dec 15, 2015

The Gemspec specifies faraday >= 0.8.0. The code in JsonApiClient::Middleware::Status references Faraday::ConnectionFailed, which is defined in faraday 0.9 and above. Not sure if other places reference 0.9 specific classes as well.
@chingor13
Copy link
Collaborator

Thanks, I will update

@chingor13 chingor13 mentioned this issue Feb 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Up the faraday gem requirement to ~> 0.9 JsonApiClient/json_api_client
2 participants
@chingor13 @drock