Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update gradle configuration #5

Merged
merged 3 commits into from
Nov 3, 2019
Merged

Feature/update gradle configuration #5

merged 3 commits into from
Nov 3, 2019

Conversation

eliaslecomte
Copy link
Collaborator

Awesome you take up maintenance of react-native-wifi 😉.
In this PR:

  • add gradle wrapper (so the android folder can be loaded in Android Studio)
  • add correct repositories to the build.gradle
  • target latest android sdk

@JuanSeBestia
Copy link
Owner

image
I tried to directly compile the library in Android Studio and it has launched this error, maybe it has something to do with https://stackoverflow.com/questions/45834070/getcurrentactivity-is-not-public-com-facebook-react-bridge-react-context-canno

Maybe it's not important, i'm not sure

@JuanSeBestia
Copy link
Owner

In the same way I tried it, and the functionality of obtaining the wifi works correctly

@JuanSeBestia JuanSeBestia merged commit 475cc30 into JuanSeBestia:master Nov 3, 2019
JuanSeBestia pushed a commit that referenced this pull request Nov 3, 2019
# [2.1.0](v2.0.4...v2.1.0) (2019-11-03)

### Features

* **Android:** Update gradle configuration ([475cc30](475cc30)), closes [#5](#5)
@JuanSeBestia
Copy link
Owner

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eliaslecomte
Copy link
Collaborator Author

Hey Juan, I will open PR that fixes that exception + improve the android implementation as well soon.

@JuanSeBestia
Copy link
Owner

@eliaslecomte Awesome :)

JuanSeBestia pushed a commit that referenced this pull request Nov 18, 2019
@eliaslecomte eliaslecomte deleted the feature/update-gradle-configuration branch March 4, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants