From bb9e76a59ab8164b346b9b1c79040055ee4040c3 Mon Sep 17 00:00:00 2001 From: Juan Antonio Date: Fri, 15 Dec 2023 02:47:01 +0100 Subject: [PATCH] Fix #275 Backlight does not get back to MAX brightness after exiting backlight menu entries Backlight is set to FULL when interacting with backlight menu entries, but it is not set back to MAX when exiting from those entries. This commit corrects that behaviour. --- app/menu.c | 4 ++++ ui/menu.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/app/menu.c b/app/menu.c index 5afc1d513..ecfc245fc 100644 --- a/app/menu.c +++ b/app/menu.c @@ -1339,6 +1339,10 @@ static void MENU_Key_EXIT(bool bKeyPressed, bool bKeyHeld) if (!gCssBackgroundScan) { + /* Backlight related menus set full brightness. Set it back to the configured value, + just in case we are exiting from one of them. */ + BACKLIGHT_SetBrightness(gEeprom.BACKLIGHT_MAX); + if (gIsInSubMenu) { if (gInputBoxIndex == 0 || UI_MENU_GetCurrentMenuId() != MENU_OFFSET) diff --git a/ui/menu.c b/ui/menu.c index 327646d58..d484dbf91 100644 --- a/ui/menu.c +++ b/ui/menu.c @@ -488,6 +488,12 @@ void UI_DisplayMenu(void) bool already_printed = false; + /* Brightness is set to max in some entries of this menu. Return it to the configured brightness + level the "next" time we enter here.I.e., when we move from one menu to another. + It also has to be set back to max when pressing the Exit key. */ + + BACKLIGHT_SetBrightness(gEeprom.BACKLIGHT_MAX); + switch (UI_MENU_GetCurrentMenuId()) { case MENU_SQL: