Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settag #53

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Add settag #53

merged 1 commit into from
Nov 2, 2024

Conversation

dpaetzel
Copy link
Contributor

@dpaetzel dpaetzel commented Jul 8, 2024

I needed to tag runs after their creation (right now tags can only be added via the exposed API upon run creation), so I quickly added settag and thought I'd add a PR to make the API more complete.

settag API is quite similar to logparam (correspondingly tests are essentially a copy-paste-and-fix of the logparam tests).

@pebeto pebeto self-requested a review November 2, 2024 16:07
@pebeto pebeto added the enhancement New feature or request label Nov 2, 2024
@pebeto
Copy link
Member

pebeto commented Nov 2, 2024

Hello @dpaetzel,

Thanks for your contribution. LGTM.

@pebeto pebeto merged commit 5345a0b into JuliaAI:main Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants