Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input_scitypes for static models #26

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 9, 2024

The meaning of input_scitype for Static models was previously unclear in the MLJ spec, a fact this is corrected here. With this now clarified, the implementation for DBSCAN and HierarchicalClustering are not compliant and this PR fixes that.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb174d9) 96.05% compared to head (3c3f41f) 96.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   96.05%   96.10%   +0.05%     
==========================================
  Files           1        1              
  Lines          76       77       +1     
==========================================
+ Hits           73       74       +1     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom merged commit ad9dd8d into master Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant