Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck readme example after MLJ.jl update #12

Closed
ablaom opened this issue Aug 17, 2023 · 4 comments
Closed

Recheck readme example after MLJ.jl update #12

ablaom opened this issue Aug 17, 2023 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@ablaom
Copy link
Member

ablaom commented Aug 17, 2023

In the pending PR #10, the example does using MLJBase, MLJModels, and so forth. After we rollout the new version of MLJ that will include using MLJFlow we can simplify the example to do using MLJ and so forth.

@pebeto pebeto closed this as completed Aug 17, 2023
@ablaom ablaom reopened this Aug 17, 2023
@ablaom
Copy link
Member Author

ablaom commented Aug 17, 2023

? We haven't rolled out changes to MLJ.jl yet. We first need the new MLJBase.jl release, and then add using MLJFlow to MLJ/src/MLJ.jl`.

@ablaom
Copy link
Member Author

ablaom commented Aug 17, 2023

@pebeto I suggest reverting the readme example so that it actually works with the current MLJFlow#dev and your MLJBase PR.

@pebeto pebeto pinned this issue Aug 18, 2023
@ablaom ablaom changed the title Update the readme example after rollout of logging to MLJ.jl Recheck readme example after MLJ.jl update Aug 18, 2023
@pebeto pebeto self-assigned this Aug 20, 2023
@pebeto pebeto added the documentation Improvements or additions to documentation label Aug 20, 2023
@ablaom
Copy link
Member Author

ablaom commented Aug 24, 2023

Also, I suggest you state in the example "Requires MLJ.jl version 0.19.3 or higher."

@pebeto
Copy link
Member

pebeto commented Aug 27, 2023

Now on dev. Waiting until the next release to move it to master.

@pebeto pebeto closed this as completed Aug 27, 2023
@pebeto pebeto unpinned this issue Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants