Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain in docs that model wrappers need to overload save/restore, and so forth #194

Closed
ablaom opened this issue Mar 6, 2024 · 2 comments
Closed

Explain in docs that model wrappers need to overload save/restore, and so forth #194

ablaom opened this issue Mar 6, 2024 · 2 comments
Labels
docs

Comments

@ablaom
Copy link
Member

ablaom commented Mar 6, 2024

Context: JuliaAI/MLJ.jl#1099 (comment)
@ablaom ablaom added the docs label Mar 6, 2024
@ablaom
Copy link
Member Author

ablaom commented Mar 6, 2024

And forward other methods/traits, such as feature_importances, and so forth (see BinaryThresholdPredictor code for other examples)

@ablaom
Copy link
Member Author

ablaom commented Jun 3, 2024

Also, after JuliaAI/MLJ.jl#1125 is closed, they will need to overload MMI.constructor.

@ablaom ablaom changed the title Explain in docs that model wrappers need to overload save/restore Explain in docs that model wrappers need to overload save/restore, and so forth Jun 3, 2024
@ablaom ablaom closed this as completed Jul 3, 2024
@github-project-automation github-project-automation bot moved this to Done in General Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
General
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom