Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve an ambiguity #102

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

putianyi889
Copy link
Contributor

Apparently Base._sum must accept a dim argument, otherwise _sum(f, A::something) and _sum(A::something, dim) technically introduce an ambiguity.

@dlfivefifty
Copy link
Member

Can you add a test for the ambiguity?

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1f44868) 64.03% compared to head (78ed98d) 64.08%.

Files Patch % Lines
src/quasifill.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   64.03%   64.08%   +0.05%     
==========================================
  Files          23       23              
  Lines        1824     1824              
==========================================
+ Hits         1168     1169       +1     
+ Misses        656      655       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@putianyi889
Copy link
Contributor Author

Can you add a test for the ambiguity?

The ambiguity doesn't have any actual meaning I suppose. It just messes with the ambiguity check.

As for the coverage, I don't add any new lines so it doesn't change. Apparently the lines are never covered before.

@dlfivefifty
Copy link
Member

But can you add tests that cover those lines? We need to make sure it hasn't broken anything.

@putianyi889
Copy link
Contributor Author

I don't even know the use case of QuasiFill. Is there a downstream that depends on it?

@dlfivefifty
Copy link
Member

representing constant functions

@putianyi889
Copy link
Contributor Author

added tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants