-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve an ambiguity #102
base: master
Are you sure you want to change the base?
resolve an ambiguity #102
Conversation
Can you add a test for the ambiguity? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 64.03% 64.08% +0.05%
==========================================
Files 23 23
Lines 1824 1824
==========================================
+ Hits 1168 1169 +1
+ Misses 656 655 -1 ☔ View full report in Codecov by Sentry. |
The ambiguity doesn't have any actual meaning I suppose. It just messes with the ambiguity check. As for the coverage, I don't add any new lines so it doesn't change. Apparently the lines are never covered before. |
But can you add tests that cover those lines? We need to make sure it hasn't broken anything. |
I don't even know the use case of QuasiFill. Is there a downstream that depends on it? |
representing constant functions |
added tests |
Apparently
Base._sum
must accept adim
argument, otherwise_sum(f, A::something)
and_sum(A::something, dim)
technically introduce an ambiguity.