You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since Δb < 0, none of the conditions in the first block of if statements are satisfied, but since it ends in an elseif it just returns Nothing. I'll have to try and make it handle negatives one at a time and then inverse at the end, just like is done with e.g. Jacobi.
The text was updated successfully, but these errors were encountered:
Lowering used to be implemented before we moved the package to decomposition based connection coefficients. You will see a TODO comment in semiclassical_jacobimatrix about this as well. It's in principle not an issue to implement this using QL or reverse Cholesky, would be nice to have.
Missed that TODO comment. I think for now I'm going to just look at implementing the inv approach into ldiv rather than working with QL / reverse Cholesky itself, mimicing what's done in Jacobi
The issue is with
semijacobi_ldiv
:Since
Δb < 0
, none of the conditions in the first block ofif
statements are satisfied, but since it ends in anelseif
it just returnsNothing
. I'll have to try and make it handle negatives one at a time and then inverse at the end, just like is done with e.g.Jacobi
.The text was updated successfully, but these errors were encountered: