Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kron for AbstractFill #268

Merged
merged 7 commits into from
Jul 3, 2023
Merged

kron for AbstractFill #268

merged 7 commits into from
Jul 3, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 28, 2023

After this,

julia> f = Fill(3, 2, 4)
2×4 Fill{Int64}, with entries equal to 3

julia> kron(f, f)
4×16 Fill{Int64}, with entries equal to 9

julia> g = Zeros(2)
2-element Zeros{Float64}

julia> kron(g, g)
4-element Zeros{Float64}

julia> E = Eye(4)
4×4 Eye{Float64}

julia> kron(E, E)
16×16 Eye{Float64}

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #268 (14a0423) into master (655c089) will increase coverage by 99.75%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #268       +/-   ##
===========================================
+ Coverage    0.00%   99.75%   +99.75%     
===========================================
  Files           5        5               
  Lines         814      828       +14     
===========================================
+ Hits            0      826      +826     
+ Misses        814        2      -812     
Impacted Files Coverage Δ
src/FillArrays.jl 99.42% <ø> (+99.42%) ⬆️
src/fillalgebra.jl 100.00% <100.00%> (+100.00%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jishnub jishnub requested a review from dlfivefifty July 3, 2023 07:27
@dlfivefifty dlfivefifty merged commit e3c8eb9 into JuliaArrays:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants