Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FillMatrix times vector returns FillVector #369

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 15, 2024

Currently,

julia> Fill(2, 3, 4) * [1:4;]
3-element Vector{Int64}:
 20
 20
 20

After this,

julia> Fill(2, 3, 4) * [1:4;]
3-element Fill{Int64}, with entries equal to 20

Similarly,

julia> [1,2,3]' * Fill(2, 3, 4)
1×4 adjoint(::Fill{Int64, 1, Tuple{Base.OneTo{Int64}}}) with eltype Int64:
 12  12  12  12

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (4bfbeec) to head (42a1f86).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           8        8           
  Lines        1086     1109   +23     
=======================================
+ Hits         1085     1108   +23     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

Bump the version to v1.12

@jishnub
Copy link
Member Author

jishnub commented Aug 19, 2024

Good to go?

@dlfivefifty dlfivefifty merged commit d0988b6 into master Aug 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants