From 9c335fb63954579f39ccc24bc13b9ec5f0bf8b2b Mon Sep 17 00:00:00 2001 From: Sheehan Olver Date: Thu, 4 Jul 2024 09:44:33 +0100 Subject: [PATCH] Revert "Add (col/row)support for Inv(Triangular) (#332)" (#333) This reverts commit 4fc90053437b7a566eb2d5aa31c039acbef75c81. --- Project.toml | 2 +- ext/LazyArraysBandedMatricesExt.jl | 10 ---------- test/bandedtests.jl | 16 ---------------- 3 files changed, 1 insertion(+), 27 deletions(-) diff --git a/Project.toml b/Project.toml index 858c218..70b8057 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "LazyArrays" uuid = "5078a376-72f3-5289-bfd5-ec5146d43c02" -version = "2.1.3" +version = "2.1.2" [deps] ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a" diff --git a/ext/LazyArraysBandedMatricesExt.jl b/ext/LazyArraysBandedMatricesExt.jl index e1a2f67..b6a5f66 100644 --- a/ext/LazyArraysBandedMatricesExt.jl +++ b/ext/LazyArraysBandedMatricesExt.jl @@ -87,16 +87,6 @@ function rowsupport(::AbstractInvLayout{<:AbstractBandedLayout}, A, k) 1:n end -function colsupport(lay::AbstractInvLayout{<:TriangularLayout}, A, j) - B, = arguments(lay, A) - return colsupport(B, j) -end - -function rowsupport(lay::AbstractInvLayout{<:TriangularLayout}, A, k) - B, = arguments(lay, A) - return rowsupport(B, k) -end - isbanded(K::Kron{<:Any,2}) = all(isbanded, K.args) function bandwidths(K::Kron{<:Any,2}) diff --git a/test/bandedtests.jl b/test/bandedtests.jl index 3db51b2..5e3159b 100644 --- a/test/bandedtests.jl +++ b/test/bandedtests.jl @@ -890,20 +890,4 @@ LinearAlgebra.lmul!(β::Number, A::PseudoBandedMatrix) = (lmul!(β, A.data); A) end end -@testset "Issue #329" begin - for op in (UpperTriangular, UnitUpperTriangular) - A = UpperTriangular(ApplyArray(inv, rand(5, 5))) - B = inv(A) - @test colsupport.(Ref(B), 1:5) == Base.OneTo.(1:5) - @test rowsupport.(Ref(B), 1:5) == range.(1:5, 5) - end - - for op in (LowerTriangular, UnitLowerTriangular) - A = LowerTriangular(ApplyArray(inv, rand(15, 15))) - B = inv(A) - @test colsupport.(Ref(B), 1:15) == range.(1:15, 15) - @test rowsupport.(Ref(B), 1:15) == Base.OneTo.(1:15) - end -end - end # module \ No newline at end of file