-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Interlace #41
base: master
Are you sure you want to change the base?
Add Interlace #41
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 77.60% 76.00% -1.60%
==========================================
Files 14 15 +1
Lines 1143 1167 +24
==========================================
Hits 887 887
- Misses 256 280 +24 ☔ View full report in Codecov by Sentry. |
Was there any particular reason this stalled if you remember @dlfivefifty? I can see a version of this for infinite arrays here but a |
The whole interlace business is just in a state of mess because I wasn't entirely sure the design. The first question is: is there a need for julia> a = [1,2,3]; b = [4,5,6]; LazyBandedMatrices.BlockVec(Hcat(a,b)')
blockvec(vcat(1×3 adjoint(::Vector{Int64}) with eltype Int64, 1×3 adjoint(::Vector{Int64}) with eltype Int64)) with indices BlockedOneTo(2:2:6):
1
4
─
2
5
─
3
6
julia> BlockBroadcastArray(vcat, unitblocks(a), unitblocks(b))
3-blocked 6-element BlockBroadcastArray{Int64, 1, typeof(vcat), Tuple{BlockedVector{Int64, Vector{Int64}, Tuple{BlockedOneTo{Int64, Base.OneTo{Int64}}}}, BlockedVector{Int64, Vector{Int64}, Tuple{BlockedOneTo{Int64, Base.OneTo{Int64}}}}}}:
1
4
─
2
5
─
3
6 The second question: how to unify the different version of concatentation in ContinuumArrays.jl? See:
The types defined in the latter are more thoroughly developed but I don't remember why its in ClassicalOrthogonalPolynomials.jl. It should probably be moved to ContinuumArrays.jl and unified with the types in basisconcat.jl. We can probably discuss this in more detail at the next meeting. |
No description provided.