Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to getfield rather than getproperty for field access #137

Closed
piever opened this issue Jul 14, 2020 · 1 comment · Fixed by #167
Closed

Default to getfield rather than getproperty for field access #137

piever opened this issue Jul 14, 2020 · 1 comment · Fixed by #167
Milestone
0.5

Comments

@piever
Copy link
Collaborator

piever commented Jul 14, 2020

This makes StructArrays work by default on struct types that customize getproperty.

We should probably allow to customize this mechanism by overloading a StructArray function (say StructArray.getentry), which would need to be overloaded at the same time as staticschema and createinstance.
@piever piever added this to the 0.5 milestone Jul 14, 2020
@piever piever mentioned this issue Jul 14, 2020
Merged
@piever
Copy link
Collaborator Author

piever commented Jul 14, 2020

Probably relevant to look into Tables.getcolumn for a similar interface.

@piever piever mentioned this issue Oct 11, 2020
Closed
@piever piever mentioned this issue Jan 19, 2021
Merged
@piever piever mentioned this issue Jan 29, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

switch to component interface JuliaArrays/StructArrays.jl
1 participant
@piever