Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does sunpos accept both scalars AND vectors? #72

Closed
yakir12 opened this issue Jan 17, 2022 · 1 comment
Closed

Why does sunpos accept both scalars AND vectors? #72

yakir12 opened this issue Jan 17, 2022 · 1 comment

Comments

@yakir12
Copy link

yakir12 commented Jan 17, 2022 •
edited
Loading

Unless there is a real reason for sunpos to accept vectors, I suggest removing the implementation in

AstroLib.jl/src/sunpos.jl

Line 139 in 5493395

function sunpos(jd::AbstractArray{J}; radians::Bool=false) where {J<:Real}
.
@giordano
Copy link
Member

Because it returns a tuple of vectors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giordano @yakir12